local data backend: optimise for abspath lookups#2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
list_filesmethod insimpletuner/helpers/data_backend/local.pyto improve file extension filtering and simplify file path handling. The main changes focus on how file extensions are matched and how file paths are constructed and returned.File extension filtering and path handling improvements:
str.endswith, instead of a set of extensions without the dot.Pathobjects and instead usingos.path.abspathandos.path.jointo build absolute file paths.Pathobjects for each file found, as noted in the updated docstring and code.Code cleanup:
Pathfrom the file.