test setup cleanup / bugfixes#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds significant improvements to the test suite and configuration for the orchestrator and worker components. The main changes include the addition of a new test configuration file for orchestrator and vLLM settings, enhanced test coverage for worker shutdown and post-execution hook behaviors, and improved pytest settings for more robust and clear testing.
Configuration and Orchestrator Enhancements:
test-config.ymlfile with comprehensive orchestrator, vLLM, storage, and authentication settings to facilitate testing and local development.Testing Improvements:
tests/test_cli.pyto verify that worker shutdown and post-exec hook behaviors can be configured and overridden via config files and CLI parameters. These tests also ensure proper validation and error handling for post-exec hook requirements.tests/test_worker_caption.pywith tests for post-exec hook execution, including successful execution, failure handling, exception handling, and full coverage for theWhenFinishedenum.tests/test_worker_caption.pyfor clarity in test failures.Test Framework Configuration:
pytest.inifile to standardize pytest behavior across the project, including asyncio settings, warning filters, and test discovery patterns.