Skip to content

test setup cleanup / bugfixes#68

Merged
bghira merged 1 commit into
mainfrom
feature/worker-shutdown-option
Jul 17, 2026
Merged

test setup cleanup / bugfixes#68
bghira merged 1 commit into
mainfrom
feature/worker-shutdown-option

Conversation

@bghira

@bghira bghira commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This pull request adds significant improvements to the test suite and configuration for the orchestrator and worker components. The main changes include the addition of a new test configuration file for orchestrator and vLLM settings, enhanced test coverage for worker shutdown and post-execution hook behaviors, and improved pytest settings for more robust and clear testing.

Configuration and Orchestrator Enhancements:

  • Added a new test-config.yml file with comprehensive orchestrator, vLLM, storage, and authentication settings to facilitate testing and local development.

Testing Improvements:

  • Added new tests to tests/test_cli.py to verify that worker shutdown and post-exec hook behaviors can be configured and overridden via config files and CLI parameters. These tests also ensure proper validation and error handling for post-exec hook requirements.
  • Extended tests/test_worker_caption.py with tests for post-exec hook execution, including successful execution, failure handling, exception handling, and full coverage for the WhenFinished enum.
  • Improved assertion formatting in tests/test_worker_caption.py for clarity in test failures.

Test Framework Configuration:

  • Introduced a pytest.ini file to standardize pytest behavior across the project, including asyncio settings, warning filters, and test discovery patterns.

@bghira
bghira merged commit e9d9523 into main Jul 17, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant