Skip to content

build/property-set.jam review#594

Open
paolopas wants to merge 1 commit intobfgroup:mainfrom
paolopas:jamme-6
Open

build/property-set.jam review#594
paolopas wants to merge 1 commit intobfgroup:mainfrom
paolopas:jamme-6

Conversation

@paolopas
Copy link
Copy Markdown
Contributor

  • removed unused imports at module/class level
  • adjusted imports for cases where just single rule was used
  • moved NATIVE_RULE declaration right below Jam rules
  • clearer condition in init-conditional method
  • leave create rule in comment for documentation purpose
  • replace ?= (which does not short-circuit) with if in create-from-user-input rule

+ removed unused imports at module/class level
+ adjusted imports for cases where just single rule was used
+ moved NATIVE_RULE declaration right below Jam rules
+ clearer condition in init-conditional method
+ leave create rule in comment for documentation purpose
+ replace ?= (which does not short-circuit) with if in
create-from-user-input rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant