Skip to content

Issue #122: Alerts unit bug fix #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wwerkk wants to merge 4 commits into from
Closed

Issue #122: Alerts unit bug fix #239

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
548d5ac
getRatio: handle units by normalizing to milisecond
wwerkk Apr 18, 2024
aac2041
fix linting
wwerkk Apr 18, 2024
9295c8a
fix typo src/write.ts
wwerkk May 2, 2024
e9edbbd
Merge branch 'master' into wwerkk/issue122
wwerkk Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/write.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,20 @@ function strVal(b: BenchmarkResult): string {
return s;
}

function toMs(value: number, unit: string) {
if (unit === undefined) return 0;
switch (unit.toLowerCase()) {
case 'us':
return value / 1e3;
case 'ms':
return value;
case 's':
return value * 1e3;
default:
return 0;
}
}

function commentFooter(): string {
const repoMetadata = getCurrentRepoMetadata();
const repoUrl = repoMetadata.html_url ?? '';
Expand Down Expand Up @@ -566,8 +580,10 @@ async function handleSummary(benchName: string, currBench: Benchmark, prevBench:

function getRatio(tool: ToolType, prev: BenchmarkResult, current: BenchmarkResult) {
if (prev.value === 0 && current.value === 0) return 1;
const prevMs = toMs(prev.value, prev.unit);
const currentMs = toMs(current.value, current.unit);
Comment on lines +583 to +584
Copy link
Member

@ktrz ktrz Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all benchmarks are output results in units of time and this logic will apply to all of them which would basically output 0 for all benchmarks that don't use us, ms or s as unit


return biggerIsBetter(tool)
? prev.value / current.value // e.g. current=100, prev=200
: current.value / prev.value; // e.g. current=200, prev=100
? prevMs / currentMs // e.g. current=100, prev=200
: currentMs / prevMs; // e.g. current=200, prev=100
}