apply fixes based on copilot comments #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request applies various code cleanup and consistency fixes based on previous Copilot review comments.
Changes:
- Added explanatory comments to module-related preprocessor directives indicating modules are disabled
- Standardized include paths to use angle brackets instead of quotes for beman headers
- Removed commented-out code from build configuration files
- Fixed incorrect filename in file header comment
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/beman/execution/thread-stoptoken-intro.test.cpp | Added comment explaining disabled modules |
| tests/beman/execution/stoptoken-mem.test.cpp | Added comment explaining disabled modules |
| tests/beman/execution/stoptoken-general.test.cpp | Added comment explaining disabled modules |
| tests/beman/execution/stopsource-inplace-general.test.cpp | Added comment explaining disabled modules |
| tests/beman/execution/stopsource-general.test.cpp | Added comment explaining disabled modules |
| tests/beman/execution/include/test/stop_token.hpp | Added comment explaining disabled modules |
| tests/beman/execution/exec-bulk.test.cpp | Standardized include paths to use angle brackets |
| tests/beman/execution/CMakeLists.txt | Removed commented-out code |
| src/beman/execution/execution.cppm | Added namespace closing comment and updated line directives |
| include/beman/execution/detail/decayed_type_list.hpp | Standardized include path to use angle brackets |
| include/beman/execution/detail/bulk.hpp | Standardized include paths to use angle brackets |
| examples/stackoverflow.cpp | Fixed incorrect filename in header comment |
| examples/CMakeLists.txt | Removed commented-out code |
| Makefile | Removed outdated comments from target definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.