Repository navigation
Correct the body text of the cancellation dialog. - #127
Merged
Merged
Conversation
2 of 3 tasks
mhsmith
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#121 modified the handling of strings to ensure that dialogs in the uninstall process actually said "uninstallation", rather than "installation" - but we missed one string, in the body text of the cancellation dialog.
This manifests when you are uninstalling, and select Cancel - the title of the dialog correctly says "[Formal name] Uninstallation", but the body says "Are you sure you want to cancel [formal name] installation?"
Also drops the XML pre-commit check; although WXS files are ultimately XML content, in this repo all the XML content is templated, which isn't parsable as XML, so the pre-commit XML check fails. An upstream check in
identify==2.6.20recently added .wxl files as "checkable" XML content, which caused pre-commit failures in this PR.Refs beeware/briefcase-windows-app-template#121.
PR Checklist: