Added Login with otp - #1095
Merged
Merged
Conversation
Added email OTP as an alternate Keycloak sign-in option Offered OTP alongside BC Services Card on the login step, allowed the otp IdP, and hardened the OAuth return path (back-button guard, prompt=login). Hardcoded learn-more links and dropped BC_SERVICES_CARD_URL from runtime config.
chrsamp
requested changes
Jul 23, 2026
chrsamp
left a comment
chrsamp
left a comment
Collaborator
There was a problem hiding this comment.
Hey @veenupunyani, nice work! Unfortunately, I hit a blocker during some testing, can you please take a look at the comment in my review and see if you can resolve it?
Collaborator
There was a problem hiding this comment.
When attempting to authenticate, if I click the browser's back button and return to the application, I am unable to authenticate again via any IdP.
Steps to reproduce:
- Go to https://dev-appointments.apps.silver.devops.gov.bc.ca/
- Choose a service and location
- Attempt to sign in with OTP
- When prompted for an email, click the browser's back button
- See "Signing you in..." message on the screen, nothing else
- Go back again (to choose a location), select a location, click Continue
- Attempt to sign in with any IdP
- See the "Signing you in..." message again, no redirect to Keycloak
What should happen:
- User clicks back from Keycloak and returns to the login page with IdP options
- User can re-attempt using any available IdP
Collaborator
Author
There was a problem hiding this comment.
good catch, fixed.
|
chrsamp
approved these changes
Jul 23, 2026
chrsamp
left a comment
chrsamp
left a comment
Collaborator
There was a problem hiding this comment.
Awesome, thank you @veenupunyani. Latest commit fixes the bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Keep rest env vars same