34225 numbered company launcher - #879
Conversation
… choose dialog Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
|
CI is passing locally - looking into issue with the PR run CI |
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
d05124e to
73fec2f
Compare
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
0b0c4b7 to
fe0ef65
Compare
… (required since CI prevents post install script) Signed-off-by: Kial Jinnah <kialj876@gmail.com>
| "test": "vitest run", | ||
| "test:unit": "vitest run", | ||
| "test": "vue-demi-fix && vitest run", | ||
| "test:unit": "vue-demi-fix && vitest run", |
There was a problem hiding this comment.
required since SRE CI installs with '--ignore-scripts'
|
/gcbrun |
|
|
/gcbrun |
3 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
Temporary Url for review: https://namerequest-dev--pr-879-721dj2ic.web.app |
meawong
left a comment
meawong
left a comment
There was a problem hiding this comment.
Nice! Tested in the preview link and LGTM
|
@kialj876 As discussed with David M, could you please hold off on merging to main until we decide when solr will be deployed to PROD? |
yep no problem |
|
Solr has been rolled back this morning so please keep holding this codes. If you want it to be merged to main earlier, please talk to David M. |
5 participants
Issue #: /bcgov/entity#34225
Description of changes:
Only shows for new incorporation for BC/ULC/CC numbered companies:
new dialog when user clicks 'help me choose':
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).