Skip to content

32906 contact email validation - #4641

Open
benjamin-bc-gov wants to merge 5 commits into
bcgov:mainfrom
benjamin-bc-gov:32906_issue
Open

32906 contact email validation#4641
benjamin-bc-gov wants to merge 5 commits into
bcgov:mainfrom
benjamin-bc-gov:32906_issue

Conversation

@benjamin-bc-gov

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#32906

Description of changes:
Contact email validation

`

All cases match the frontend behaviour exactly.

  • Alteration
  • Amalgamation Application
  • Change of Registration
  • Continuation In
  • Correction
  • Registration
  • Restoration
    `

@sonarqubecloud

Copy link
Copy Markdown

@kialj876 kialj876 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also effect incorporation application I think?

@kialj876
kialj876 requested review from meawong and mruff-aeq July 30, 2026 20:06
@meawong

meawong commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

This should also effect incorporation application I think?

yes, good catch! I've updated the ticket requirements

@kialj876

Copy link
Copy Markdown
Collaborator

Also, did you verify this is not already handled by the schema? I think this is already being validated so we don't need to revalidate it in the API
https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/contact_point.json#L13

@benjamin-bc-gov

Copy link
Copy Markdown
Collaborator Author

This should also effect incorporation application I think?

checking

@kialj876

Copy link
Copy Markdown
Collaborator

It looks like this is all already being validated by the schema so can you please close this and update it there if there's any change to be made? You can verify by adding to this test case: https://github.com/bcgov/business-schemas/blob/main/tests/unit/schemas/test_required_non_empty_strings.py#L395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants