chore: upgrade pnpm to 11.9.0 - #1781
Open
panish16 wants to merge 4 commits into
Open
Conversation
Pin pnpm_version to 11.9.0 in CI workflows, set packageManager field via corepack, and add pnpm-workspace.yaml with allowBuilds for native deps (@parcel/watcher, esbuild, sharp, unrs-resolver) required under pnpm 11's stricter build-script gating.
panish16
force-pushed
the
feat/upgrade-pnpm-v11
branch
from
August 3, 2026 18:53
3e3324b to
1a3853c
Compare
pnpm 11's stricter hoisting no longer resolves tailwindcss transitively for eslint-plugin-tailwindcss in examiner/host-pm/platform/strata, crashing eslint entirely (Could not find tailwindcss). It was already present in each lockfile as a transitive dep; declaring it directly fixes resolution without changing the resolved version (3.4.19).
The git-hosted layer reference (github:bcgov/STRR/strr-base-web) is cloned by giget into an isolated node_modules/.c12/<hash> tree with no node_modules of its own, so its tsconfig.json (and anything depending on generated .nuxt/tsconfig.json) can't resolve under pnpm 11's resolution behavior. This broke nuxt prepare for all 4 downstream apps, which in turn broke both eslint's typescript/import resolvers (200+ spurious lint errors) and the Nuxt build itself. Switching to a local relative-path extends avoids the git-clone isolation entirely. Since the sibling app's own .nuxt/tsconfig.json may not exist in a fresh checkout (CI only runs each app's own nuxt prepare), each consuming app eagerly installs and prepares strr-base-web if missing, before Nuxt evaluates its config.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const __dirname = dirname(fileURLToPath(import.meta.url)) | ||
| const baseWebDir = resolve(__dirname, '../strr-base-web') | ||
| if (!existsSync(resolve(baseWebDir, 'node_modules'))) { | ||
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) |
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) | ||
| } | ||
| if (!existsSync(resolve(baseWebDir, '.nuxt/tsconfig.json'))) { | ||
| execSync('npx --yes nuxi prepare', { cwd: baseWebDir, stdio: 'inherit' }) |
| const __dirname = dirname(fileURLToPath(import.meta.url)) | ||
| const baseWebDir = resolve(__dirname, '../strr-base-web') | ||
| if (!existsSync(resolve(baseWebDir, 'node_modules'))) { | ||
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) |
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) | ||
| } | ||
| if (!existsSync(resolve(baseWebDir, '.nuxt/tsconfig.json'))) { | ||
| execSync('npx --yes nuxi prepare', { cwd: baseWebDir, stdio: 'inherit' }) |
| const __dirname = dirname(fileURLToPath(import.meta.url)) | ||
| const baseWebDir = resolve(__dirname, '../strr-base-web') | ||
| if (!existsSync(resolve(baseWebDir, 'node_modules'))) { | ||
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) |
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) | ||
| } | ||
| if (!existsSync(resolve(baseWebDir, '.nuxt/tsconfig.json'))) { | ||
| execSync('npx --yes nuxi prepare', { cwd: baseWebDir, stdio: 'inherit' }) |
| const __dirname = dirname(fileURLToPath(import.meta.url)) | ||
| const baseWebDir = resolve(__dirname, '../strr-base-web') | ||
| if (!existsSync(resolve(baseWebDir, 'node_modules'))) { | ||
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) |
| execSync('npx --yes pnpm install --ignore-scripts', { cwd: baseWebDir, stdio: 'inherit' }) | ||
| } | ||
| if (!existsSync(resolve(baseWebDir, '.nuxt/tsconfig.json'))) { | ||
| execSync('npx --yes nuxi prepare', { cwd: baseWebDir, stdio: 'inherit' }) |
All 4 STRR frontend CD files (examiner/host-pm/platform/strata) were still hardcoded to pnpm_version: 10.0.0, unrelated to and never touched by the pnpm-v11 CI migration on this branch.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh PR replacing #1747 (closed while testing was still in progress).
Scoped strictly to pnpm 11.9.0: version pins (
pnpm_version,packageManager,pnpm/action-setup@v6),--ignore-scriptswhere needed, and pinning the smoke-test workflows off the floatinglatest-11tag.Note: strr-examiner-web, strr-host-pm-web, strr-platform-web, and strr-strata-web will still fail
verify-build— this is the pre-existing, already-known upstream Nuxt/c12#importsresolution bug for git-hosted layers (unrelated to pnpm, confirmed via A/B test against the pre-pnpm-11 code). Deliberately left unfixed here per @panish16's request to keep this PR pnpm-only.