fix(batch-permit-job): use runtime auth for storage - #1768
Open
Jacky-Pham wants to merge 1 commit into
Open
Conversation
Jacky-Pham
requested review from
JazzarKarim,
dimak1,
jimmypalelil and
thorwolpert
as code owners
July 14, 2026 21:33
|
| """Build and return an authenticated GCS storage client.""" | ||
| project_id = current_app.config.get("GCP_CS_PROJECT_ID") | ||
| credentials = None | ||
| if auth_key := current_app.config.get("GCP_AUTH_KEY"): |
Collaborator
There was a problem hiding this comment.
the auth key is being used here but removed above. this will result in job failures
| """Gets the presigned url for a file.""" | ||
| bucket = cls.get_bucket(bucket_id) | ||
| storage_client = cls._create_storage_client() | ||
| bucket = storage_client.bucket(bucket_id) |
Collaborator
There was a problem hiding this comment.
get_bucket method already exists above
|
|
||
| credentials = storage_client._credentials # pylint: disable=protected-access | ||
| if credentials and not isinstance(credentials, service_account.Credentials): | ||
| credentials.refresh(Request()) |
Collaborator
There was a problem hiding this comment.
do we really need to refresh the credentials. wont google manage that automatically since the job is running on GCP Cloud Run?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary