WS-2860-Topic Discovery: Front end work to support roll out - a11y#14168
Open
Nabeel1276 wants to merge 13 commits into
Open
WS-2860-Topic Discovery: Front end work to support roll out - a11y#14168Nabeel1276 wants to merge 13 commits into
Nabeel1276 wants to merge 13 commits into
Conversation
…com/bbc/simorgh into WS-2860-Frontend-work-to-support-a11y
pvaliani
reviewed
Jul 7, 2026
| return; | ||
| } | ||
|
|
||
| event.preventDefault(); |
Contributor
There was a problem hiding this comment.
I think this stops the normal tab key before we know there is another topic to move to. On the last topic, pressing tab on the "More About" link is doing nothing for me, so keyboard users can get stuck there. Does it do that for you?
Might need to only call preventDefault() when a next tab exists and if there is no next tab, let the browser move focus to the next thing on the page.
Everything else in the PR LGTM for the a11y rollout!
Contributor
There was a problem hiding this comment.
Same happens to me on the More About link
Contributor
Author
There was a problem hiding this comment.
Yes the issue was happening to me too, I have solved it now so that tab focus moves to the next section of the page. Good catch!
holchris
reviewed
Jul 7, 2026
pvaliani
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2860
Summary
Following an A11y swarm, there were a various number of minor issues that needed resolved. This PR improves the accessibility and keyboard navigation of the Topic Discovery component to support wider rollout. The changes ensure the component behaves more consistently for keyboard and screen reader users, improves compatibility with High Contrast mode, and aligns the experience with A11y swarm feedback.
Code changes
CanvasTextthat represents the default text colour used on a canvas/background, adapting to the user’s theme or accessibility settings.Scenario 1 - The screenreader just goes through all the topics on the scrollableTabs and then onto the first article of the first topic, in this case being Cuba.
Scenario 2 - When a user selects a topic, we are wanting to go through all the articles of that selected topic (including the more from link) and once finished, we are wanting to go on the next topic in the scrollableTabs. So if a user selects Cuba, the screenreader should go through all the articles for Cuba, the more from link and then Politica.
Testing
Useful Links