Remove needless borrows#421
Open
WhyNotHugo wants to merge 1 commit into
Open
Conversation
These borrows are unnecessary (and rust-analyser complains about them
constantly). These changes programmatically done with:
cargo clippy --fix -- -A clippy::all -W clippy::needless_borrows_for_generic_args
|
Ah TIL clippy has auto fix. If this doesn't get accepted, I'll happily accept this in Cadmus(Plato fork). There clippy is configured to only warn on the diff, instead of the whole project, in CI. This was my approach to slowly deal with clippy warnings. |
Author
|
You also have the syntax to fix individual lints right there (makes reviewing changes much easier than doing them all at once). :)
|
|
Yeah. Definitely worth auto-fixing the ones that can to reduce the list 👍🏾. I don't think PRs are accepted though, see #414. If it happens to be, I'll "cherry-pick" them. If not, you're always welcome to submit them in the fork. Anyhow, thanks for the tip. Your device tree PR certainly looks interesting. I had a private todo to see if those magic variables could be replaced. Good too see that there is 😆. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These borrows are unnecessary (and rust-analyser complains about them constantly). These changes programmatically done with: