Skip to content

Remove needless borrows#421

Open
WhyNotHugo wants to merge 1 commit into
baskerville:masterfrom
WhyNotHugo:needless_borrows_for_generic_args
Open

Remove needless borrows#421
WhyNotHugo wants to merge 1 commit into
baskerville:masterfrom
WhyNotHugo:needless_borrows_for_generic_args

Conversation

@WhyNotHugo
Copy link
Copy Markdown

These borrows are unnecessary (and rust-analyser complains about them constantly). These changes programmatically done with:

cargo clippy --fix -- -A clippy::all -W clippy::needless_borrows_for_generic_args

These borrows are unnecessary (and rust-analyser complains about them
constantly). These changes programmatically done with:

    cargo clippy --fix -- -A clippy::all -W clippy::needless_borrows_for_generic_args
@OGKevin
Copy link
Copy Markdown

OGKevin commented May 21, 2026

Ah TIL clippy has auto fix. If this doesn't get accepted, I'll happily accept this in Cadmus(Plato fork).

There clippy is configured to only warn on the diff, instead of the whole project, in CI. This was my approach to slowly deal with clippy warnings.

@WhyNotHugo
Copy link
Copy Markdown
Author

WhyNotHugo commented May 21, 2026 via email

@OGKevin
Copy link
Copy Markdown

OGKevin commented May 22, 2026

Yeah. Definitely worth auto-fixing the ones that can to reduce the list 👍🏾.

I don't think PRs are accepted though, see #414. If it happens to be, I'll "cherry-pick" them. If not, you're always welcome to submit them in the fork. Anyhow, thanks for the tip.

Your device tree PR certainly looks interesting. I had a private todo to see if those magic variables could be replaced. Good too see that there is 😆.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants