Skip to content

fix(account): let session-key signer field mint a spare key - #111

Closed
montycheese wants to merge 1 commit into
mainfrom
fix/session-key-signer-mint
Closed

fix(account): let session-key signer field mint a spare key#111
montycheese wants to merge 1 commit into
mainfrom
fix/session-key-signer-mint

Conversation

@montycheese

Copy link
Copy Markdown
Contributor

Summary

  • On a typical account (single owner, or after adding a second owner), every signer in the local wallet is already an owner or session key of that account, so every entry in the "Register a Session Key" Signer dropdown is disabled. Radix blocks clicks on disabled options entirely, so skSignerId never gets set and "Sign Authorization" stays permanently grayed out — session keys can't be created and no signer can be selected.
  • Add a "+ New signer" action next to the Signer field that mints a fresh K1 key via the existing createSigner engine method and selects it immediately, giving the form a real, selectable signer without leaving the modal.

Test plan

  • npx tsc --noEmit passes
  • Reproduced the bug against a fresh single-owner account and confirmed clicking the disabled owner entry does nothing (Sign Authorization stays disabled)
  • Verified the fix end-to-end in a browser: clicking "+ New signer" mints and selects a key, "Sign Authorization" enables, and the session key registers successfully

Every signer in the wallet is either already an owner or session key on
a freshly created (or two-owner) account, so the Signer dropdown's only
entries are disabled and unclickable — Sign Authorization can never
enable. Add a "+ New signer" action that mints a fresh key and selects
it directly.
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
omni-ui Ready Ready Preview Aug 28, 2026 5:18pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants