fix: validate certificate public key encoding#42
Open
leanthebean wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CAT finding
8e9d6651-3110-4974-be61-b5f1db6f9206.CertManager._parsePubKeypreviously assumed the SubjectPublicKeyInfo BIT STRING was the expected uncompressed P-384 point and sliced the last 96 bytes. A non-standard BIT STRING length could therefore cause the parser to cache bytes outside the intended(x,y)public key.This change:
0x04;Self Review
Reviewed the final diff before opening this PR. The production change is scoped to
_parsePubKey, preserves the valid AWS Nitro P-384 uncompressed point path, and rejects the malformed SPKI shapes from the finding instead of relying on downstream curve checks or raw slice bounds.Tests
forge test --match-path test/CertManager.t.sol -vvvforge test