fix(L1): allow simultaneous upgrade rescheduling - #419
Merged
Conversation
Permit an earlier upgrade to move to its successor's timestamp so owner and incident-responder delays can preserve atomic activation. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
Update the generated contract hashes after changing the timestamp ordering check. Co-authored-by: Cursor <cursoragent@cursor.com>
leopoldjoy
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Allow a protocol upgrade timestamp to equal its next scheduled successor so multiple protocol versions can activate simultaneously. Updates the next-timestamp validation and error NatSpec, with the corresponding semver lock refresh.
Notes to reviewers
The existing requirement that an upgrade remain after its previous scheduled predecessor is unchanged. Timestamps later than the next scheduled successor continue to revert.
How has it been tested?
forge test --match-path test/L1/ProtocolVersions.t.solforge fmt --check src/L1/ProtocolVersions.sol test/L1/ProtocolVersions.t.sol