docs(L1): document AggregateVerifier L1 origin split - #418
Merged
Conversation
Explain that initialization proofs journal a verified proof-supplied origin while later proof paths use the factory-captured l1Head. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
Regenerate the AggregateVerifier semver lock across both documentation updates. Co-authored-by: Cursor <cursoragent@cursor.com>
Consolidate the initialization proof layout into its parameter documentation so the proof-type description is precise and non-redundant. Co-authored-by: Cursor <cursoragent@cursor.com>
leopoldjoy
approved these changes
Aug 24, 2026
Collaborator
|
Review Error for leopoldjoy @ 2026-08-24 19:45:08 UTC |
leopoldjoy
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
initializeWithInitDataproof encoding: proof type, L1 origin hash, L1 origin number, and verifier payload.verifyProposalProof,challenge, andnullifyjournal the factory-capturedl1Head.AggregateVerifiersemver source hash for the NatSpec change.This makes the two L1-origin paths explicit so readers do not infer that initialization requires the game-creation
l1Head.Notes to reviewers
This changes NatSpec only; runtime behavior and the init-code hash are unchanged.
How has it been tested?
just semver-lockjust test --match-path test/L1/proofs/AggregateVerifier.t.solforge fmt --checkgit diff --check