Skip to content

docs(L1): document AggregateVerifier L1 origin split - #418

Merged
jackchuma merged 3 commits into
mainfrom
docs/aggregate-verifier-l1-origin-provenance
Aug 24, 2026
Merged

docs(L1): document AggregateVerifier L1 origin split#418
jackchuma merged 3 commits into
mainfrom
docs/aggregate-verifier-l1-origin-provenance

Conversation

@jackchuma

@jackchuma jackchuma commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What changed? Why?

  • Clarify the initializeWithInitData proof encoding: proof type, L1 origin hash, L1 origin number, and verifier payload.
  • Document that initialization validates and journals the proof-supplied L1 origin, while verifyProposalProof, challenge, and nullify journal the factory-captured l1Head.
  • Update the AggregateVerifier semver source hash for the NatSpec change.

This makes the two L1-origin paths explicit so readers do not infer that initialization requires the game-creation l1Head.

Notes to reviewers

This changes NatSpec only; runtime behavior and the init-code hash are unchanged.

How has it been tested?

  • just semver-lock
  • just test --match-path test/L1/proofs/AggregateVerifier.t.sol
  • forge fmt --check
  • git diff --check

Explain that initialization proofs journal a verified proof-supplied origin while later proof paths use the factory-captured l1Head.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cb-heimdall

cb-heimdall commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

jackchuma and others added 2 commits August 24, 2026 15:32
Regenerate the AggregateVerifier semver lock across both documentation updates.

Co-authored-by: Cursor <cursoragent@cursor.com>
Consolidate the initialization proof layout into its parameter documentation so the proof-type description is precise and non-redundant.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for leopoldjoy @ 2026-08-24 19:45:08 UTC
User failed mfa authentication, see go/mfa-help

@jackchuma
jackchuma merged commit 90de369 into main Aug 24, 2026
6 checks passed
@jackchuma
jackchuma deleted the docs/aggregate-verifier-l1-origin-provenance branch August 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants