fix(highlight): omit DiffsClear bg on transparent themes#179
Merged
barrettruth merged 1 commit intomainfrom Mar 8, 2026
Merged
fix(highlight): omit DiffsClear bg on transparent themes#179barrettruth merged 1 commit intomainfrom
barrettruth merged 1 commit intomainfrom
Conversation
Problem: #178 set `DiffsClear.bg` to a dark fallback (`#1a1a1a`) on transparent themes, painting a visible solid rectangle where the terminal background should show through. Solution: only set `DiffsClear.bg` when `Normal.bg` is defined. Body lines are already protected by `line_hl_group` (`DiffsAdd`/ `DiffsDelete`), which stacks above `hl_group` bg regardless of priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#178 set
DiffsClear.bgto a dark fallback (#1a1a1a) on transparent themes, painting a visible solid rectangle where the terminal background should show through.Solution
Only set
DiffsClear.bgwhenNormal.bgis defined. Body lines are already protected byline_hl_group(DiffsAdd/DiffsDelete), which stacks abovehl_groupbg regardless of priority —DiffsClear.bgis redundant there. The only site where it matters is combined/email-quoted diff headers, an acceptable tradeoff.