Skip to content

Adding ComponentType enum for PatchComponentSites#213

Merged
allison-li-1016 merged 3 commits intomainfrom
allison/make-components-enum
Mar 26, 2026
Merged

Adding ComponentType enum for PatchComponentSites#213
allison-li-1016 merged 3 commits intomainfrom
allison/make-components-enum

Conversation

@allison-li-1016
Copy link
Copy Markdown
Contributor

Anticipated review time: xs

Description:

  • I added enums to describe the component type for PatchComponentSites.
  • I also an abstract method with method implementations in each subclass so that the components can return the ComponentType enum associated with the class.

This is PR is in anticipation of the Treat class for the CARCADE refactor, I thought it would be more modular for this to be its own PR instead of lumping it together with Treat.

@allison-li-1016 allison-li-1016 requested review from a team, Jannetty, afu5, cainja, jacob-evarts, jessicasyu, kristaphommatha and pohaoc2 and removed request for a team March 23, 2026 20:25
Copy link
Copy Markdown
Member

@Jannetty Jannetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Copy Markdown
Contributor

@kristaphommatha kristaphommatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allison-li-1016 allison-li-1016 merged commit 3e14292 into main Mar 26, 2026
6 checks passed
@allison-li-1016 allison-li-1016 deleted the allison/make-components-enum branch March 26, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants