Nomad plugin migration - #9841
Closed
deepthi-28 wants to merge 2 commits into
Closed
Conversation
Contributor
Changed Packages
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Nomad frontend plugin workspace from legacy Material-UI (MUI v4) components/icons to Backstage UI (BUI) and Remix Icon components, aligning the plugin UI with the newer Backstage UI stack.
Changes:
- Replaced MUI
ChipandOpenInNewusage with BUITag/TagGroupand@remixicon/react. - Updated plugin dependencies (and lockfile) to remove
@material-ui/*and add@backstage/ui+@remixicon/react. - Added a changeset documenting the migration release.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| workspaces/nomad/yarn.lock | Updates lockfile entries for the new UI/icon dependencies and removes MUI v4 entries for this workspace. |
| workspaces/nomad/plugins/nomad/src/components/EntityNomadJobVersionListCard/EntityNomadJobVersionListCard.tsx | Migrates UI elements from MUI to BUI and swaps action icon to Remix Icon. |
| workspaces/nomad/plugins/nomad/package.json | Removes MUI dependencies and adds @backstage/ui and @remixicon/react. |
| workspaces/nomad/.changeset/gorgeous-weeks-flash.md | Adds a changeset announcing the migration release. |
Comment on lines
+51
to
+53
| <TagGroup aria-label="stable"> | ||
| <Tag id="stable">{`${row.Stable}`}</Tag> | ||
| </TagGroup> |
Comment on lines
+139
to
142
| icon: () => <RiExternalLinkLine />, | ||
| tooltip: 'Open in Nomad UI', | ||
| isFreeAction: true, | ||
| onClick: () => window.open(`${nomadAddr}/ui/jobs/${jobID}/versions`), |
Comment on lines
+44
to
+45
| "@backstage/ui": "backstage:^", | ||
| "@remixicon/react": "^4.2.0", |
Contributor
Author
|
Hi @Parsifal-M, I followed the same steps for the MUI to BUI conversion as outlined here: #7869. Please review. |
deepthi-28
force-pushed
the
nomad_plugin_migration
branch
3 times, most recently
from
August 1, 2026 00:36
ea51a4e to
a754759
Compare
Contributor
|
Thanks for the contribution! |
deepthi-28
force-pushed
the
nomad_plugin_migration
branch
2 times, most recently
from
August 1, 2026 01:13
a754759 to
96ac772
Compare
Signed-off-by: deepthi-ajith_infosys <deepthi.ajith@infosys.com>
deepthi-28
force-pushed
the
nomad_plugin_migration
branch
from
August 1, 2026 01:38
452be1b to
2528a48
Compare
Signed-off-by: deepthi-ajith_infosys <deepthi.ajith@infosys.com>
Contributor
Author
|
Closing this PR as the changes have been moved to a new PR. Please continue the review on the newly created PR. - #10234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
✔️ Checklist
Signed-off-byline in the message. (more info)