fix(review): make the Edit Mode opt-in an explicit switch, not a primary CTA - #1213
Merged
Merged
Conversation
…ary CTA The announcement footer's primary Turn it on button read as a generic continue and invited blind clicks: opting into an experimental feature was one reflexive Enter away. The decision is now an explicit Enable Edit Mode switch (defaulting off, with the shared TextShimmer label treatment) beside a single neutral Done button that applies whatever the switch says. Pressing Done untouched is a plain dismissal, and the focused default action is asserted consent-neutral in tests. Announcement cookie version bumped so the revision re-shows (pre-release, no users have the old cookie).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: The Edit Mode announcement's footer had a primary Turn it on button that read as a generic continue, so users could opt into an experimental feature with a reflex click. The opt-in is now an explicit Enable Edit Mode switch (off by default, with the shared TextShimmer label) next to a single neutral Done button that applies whatever the switch says. Done with the switch untouched is a plain dismissal.
Maintainer flagged the original pair as a dark-UX pattern after trying it live. Tests assert the focused default action is consent-neutral, the switch toggles round-trip, and flipping it then Done fires the enable path. Announcement cookie version bumped to re-show the revision; pre-release, so no released user has the old cookie.
AI-assisted.