[Security Fix]: Fix the Cypher safety bypass vulnerabilities#291
Open
oussamahansal wants to merge 3 commits into
Open
[Security Fix]: Fix the Cypher safety bypass vulnerabilities#291oussamahansal wants to merge 3 commits into
oussamahansal wants to merge 3 commits into
Conversation
|
BYOKG-RAG Coverage Report: The coverage is at unknown% (target: unknown%). Download the HTML report here. |
|
BYOKG-RAG Coverage Report: The coverage is at 94.25% (target: 80%). Download the HTML report here. |
mykola-pereyma
approved these changes
May 28, 2026
acarbonetto
reviewed
May 29, 2026
Collaborator
acarbonetto
left a comment
acarbonetto
left a comment
There was a problem hiding this comment.
A few minor comments to address.
acarbonetto
reviewed
Jun 1, 2026
Collaborator
acarbonetto
left a comment
acarbonetto
left a comment
There was a problem hiding this comment.
Can you add a integration test for this? We should add this test to the short playlist.
|
BYOKG-RAG Coverage Report: The coverage is at 94.25% (target: 80%). Download the HTML report here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
GraphQueryRetriever.is_query_safe()by hardening the method with comment stripping, Unicode normalization, expanded blocklist (includingCALL), restoring theblock_graph_modificationflag, and adding driver-level read-only enforcement viaNeptuneAnalyticsGraphStore.execute_query().By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.