[Benchmarking]: Add multi-retriever comparison benchmarking with per-query metrics#290
Open
oussamahansal wants to merge 4 commits into
Open
[Benchmarking]: Add multi-retriever comparison benchmarking with per-query metrics#290oussamahansal wants to merge 4 commits into
oussamahansal wants to merge 4 commits into
Conversation
…it's retrieval strategies.
Collaborator
mykola-pereyma
left a comment
There was a problem hiding this comment.
Please remove meta information from tests about requirements or indexed property or replace with explicit description.
Please add date when cost was estimated to ensure clients will not be confused later when prices will change.
added 2 commits
May 28, 2026 13:46
acarbonetto
approved these changes
May 28, 2026
|
|
||
| ## Running Benchmarks | ||
|
|
||
| ### CUAD (Build → Query → Evaluate) |
Collaborator
There was a problem hiding this comment.
not sure if the prototype cuad dataset is useful for sanity checks.
If not, maybe we should remove the dataset.
Collaborator
Author
There was a problem hiding this comment.
I Think we can keep it if we want to validate pipeline in 2 min before multi-hour runs
mykola-pereyma
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add retriever parameterization, per-query latency/token tracking, aggregate metrics summaries, and cross-retriever comparison reporting to the benchmarking framework.
What's included:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.