Add support for server side hooks

[ajjl]

Client side hooks are great, but rely on developers properly setting
them up and not taking shortcuts. Server side hooks provide an
opportunity to enforce security policies at a more global level.

This commit adds an "update_hook" option which can be added as a
serverside update hook. It scans the pushed commits for secrets.

Fixes issue: #79

[ajjl]

Please let me know what if anything, I should do for tests.

[bjbishop]

This would be really useful! Thanks @ajjl

[ramya-ravula-ctr]

can we enforce this on public github or it is only for github enterprise appliance ?

[ajjl]

@ramya-ravula-ctr I dont think this works on publicly hosted github. I don't know about github enterprise is set up but I imagine it would work. This is meant for a git server that you have control over. An example would be a self hosted gitlab server.

[ramya-ravula-ctr]

Thanks @ajjl for the response. i figured out it's not for publicly hosted github and public github only supports client side hooks.

[ajjl]

@mtdowling any thoughts on this feature?

[ajjl]

anybody... @mtdowling ?

[rix0rrr]

I was looking into this as well, and was wondering the following:

Where do you store your "secret patterns"?

Normally they get stored in .git/config, but that file does not get shared between clones. So where does the server get the list of prohibited patterns?

[ajjl]

Hi @rix0rrr
Using gitlab I have the secrets in the .gitconfig file in the home folder of the git user on the gitlab server. I am not sure how it would be set up in other environments

[mtdowling]

Sorry for the delay! I was on paternity leave and then dropped the ball on reviewing this.

I've left some comments on the review.

[ajjl]

Thanks for the review @mtdowling! I will take a look at this this weekend or next week and get back to you.

[ajjl]

Also congrats on your new/bigger family! @mtdowling

[uleinal]

Wow, I totally lost track of this, anyways, I added the comment into the code, and rebased the branch. Let me know if you want anymore changes before merging @mtdowling

[ajjl]

That was me up there logged into my work account. Hopefully not too confusing.

[mtdowling]

Everything is looking good here. The only thing that I think is missing is tests. Is that something you can add?

[sparr]

I think this is ready along with the tests in #204.

All comments resolved.

[sparr]

Close and reopen to trigger tests

[sparr]

LGTM.
Confirming that new tests in #204 pass.