Open
Conversation
- adds quotes to prevent `git-secrets` breaking and erroring out in some bash configurations
Author
|
@mtdowling @rajeevravindran friendly ping on this one |
|
This fix worked for me too. Worst thing about the issue is that there is no useful error message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git-secretsbreaking and erroring out in some bash configurationsIssue #, if available:
N/A
Description of changes:
adds quotes to a couple of commands that without quotes make it erroring out in some bash configurations
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.