Change --list to only search for secrets section and not everything#166
Closed
mobilutz wants to merge 1 commit intoawslabs:masterfrom
mobilutz:patch-1
Closed
Change --list to only search for secrets section and not everything#166mobilutz wants to merge 1 commit intoawslabs:masterfrom mobilutz:patch-1
--list to only search for secrets section and not everything#166mobilutz wants to merge 1 commit intoawslabs:masterfrom
mobilutz:patch-1
Conversation
Contributor
|
Good catch on the misbehavior and fix! The pattern should also have a literal dot, so it won't match |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
I stumbled over a problematic situation, because my
git confighad some content withsecretsin it. The config that had this in it is:When running
git secrets --list, it showed me two files because the regex is not looking for the section but just for anysecrets.*string.With this change,
git secrets --listonly returns the configuration in thesecretssection of gitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.