Skip to content

Fixed S3 Java files so tests all pass#7903

Merged
scmacdon merged 6 commits into
awsdocs:mainfrom
scmacdon:s3fixtests
May 21, 2026
Merged

Fixed S3 Java files so tests all pass#7903
scmacdon merged 6 commits into
awsdocs:mainfrom
scmacdon:s3fixtests

Conversation

@scmacdon
Copy link
Copy Markdown
Contributor

This pull request made fixes to the Java S3 tests so they all pass.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon self-assigned this May 15, 2026
@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Bug An update to fix incorrect code or typos. labels May 15, 2026
@scmacdon scmacdon changed the title Fixed S2 Java files so tests all pass Fixed S3 Java files so tests all pass May 15, 2026
Copy link
Copy Markdown
Collaborator

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs proper handling of required bucket names that will work with the tests. You'll need a way to put a real bucket name for tests, such as: create/destroy the bucket as part of the test, provide the bucket name as a parameter, etc, but not hard-code a non-approved name into any of the actual examples.

@scmacdon
Copy link
Copy Markdown
Contributor Author

scmacdon commented May 15, 2026

Results are

Bucket names inside snippet regions: All compliant (amzn-s3-demo- prefix)
No hardcoded credentials
No critical unused imports in the files
All 85 tests passing

@scmacdon scmacdon added the On Call Review complete On call review complete label May 21, 2026
@scmacdon scmacdon merged commit 0a2b7b1 into awsdocs:main May 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An update to fix incorrect code or typos. Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants