Conversation
src/main/java/com/amazonaws/services/neptune/cli/GraphSchemaProviderModule.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazonaws/services/neptune/export/NeptuneExportService.java
Outdated
Show resolved
Hide resolved
…S3 requests, if they don't pass in the value, use credential provider for default accountID.
97b953a to
8e3260c
Compare
|
Thanks for all of the changes. Everything looks good to me. I'm noticing 2 of the tests are failing in the CI, but those when checking out the branch and running them locally they seem fine. I think that's likely a bug in the CI environment and unrelated to these changes. I will look into that closer tomorrow. |
Cole-Greer
left a comment
There was a problem hiding this comment.
I pushed a commit with 1 small change (burying the call to s3CredentialsProvider.resolveCredentials() inside a try-catch), as that call was leading to some unit tests failing in environments with no credentials set. I feel it's best to simply swallow and log that exception as I think it's best to avoid interfering with any existing working use cases (especially ones where an S3 upload is skipped, and these changes have no relevancy).
I believe the PR is good to merge now. Any thoughts regarding this change @vaibhavm99?
Add S3 Bucket Owner Verification Support
This PR adds optional S3 bucket owner verification to neptune-export, enhancing security by allowing clients to verify that S3 buckets are owned by expected AWS accounts.
Changes
New Parameter: expectedBucketOwner
Security Benefits
This feature helps prevent unauthorized access to S3 buckets by verifying bucket ownership before performing operations, adding an extra layer of security for cross-account scenarios.