feat: support ?s ?p ?o shorthand in SPARQL query results#1769
Merged
Conversation
Fixes aws#1766 - Modifies sparqlQuadBindingSchema in types.ts to support shorthand aliases natively - Transforms validated shorthand schema structures back to canonical form - Updates rawQuery and parseAndMapQuads test cases to validate new schema mapping behaviors
2652972 to
7e9f6a4
Compare
kmcginnes
reviewed
May 15, 2026
kmcginnes
reviewed
May 15, 2026
Collaborator
kmcginnes
left a comment
There was a problem hiding this comment.
This looks good to me. Just run pnpm format at the root to fix the formatting issues.
Collaborator
|
Tested this locally and it works as expected. |
Contributor
Author
|
@kmcginnes i did see that there was a CVE in one of the packages for which the build was failing on the previous run. The CVE is pre-existing on main and would need a separate dependency bump to resolve. Happy to file a follow-up issue and work on the fix as well if useful. |
Collaborator
|
If you rebase on main you should get the fix. Unless there's been another one since. |
Contributor
Author
|
fair point. just merged main. |
kmcginnes
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR supports the
?s ?p ?oshorthand in the Query Editor so results render correctly as graph entities.Changes include:
sparqlQuadBindingSchemato normalize the{s, p, o}short form into{subject, predicate, object}.SELECT ?s ?p ?oexecutes and behaves as aCONSTRUCTquery.Related Issues
Fixes #1766
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.