Skip to content

Consolidate EC_KEY key check functions#3018

Draft
torben-hansen wants to merge 1 commit intoaws:mainfrom
torben-hansen:consolidate_ec_key_check
Draft

Consolidate EC_KEY key check functions#3018
torben-hansen wants to merge 1 commit intoaws:mainfrom
torben-hansen:consolidate_ec_key_check

Conversation

@torben-hansen
Copy link
Copy Markdown
Contributor

Description of changes:

Reduce number of code-paths to a single public key validation function that runs through required FIPS check, always.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.31%. Comparing base (ab1b674) to head (69cc5d8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/ec/ec_key.c 71.42% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3018   +/-   ##
=======================================
  Coverage   78.31%   78.31%           
=======================================
  Files         689      689           
  Lines      121007   121004    -3     
  Branches    16996    16993    -3     
=======================================
+ Hits        94765    94769    +4     
+ Misses      25346    25339    -7     
  Partials      896      896           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants