feat<events.cognito>: add support for custom email sender#419
feat<events.cognito>: add support for custom email sender#419BorisLeMeec wants to merge 4 commits intoaws:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 71.66% 71.66%
=======================================
Files 19 19
Lines 1041 1041
=======================================
Hits 746 746
Misses 228 228
Partials 67 67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, do you have an AWS docs link for this feature that I can reference? |
|
Can we cover custom SMS sender as well? |
|
Sure, I will add the same for SMS, I have few time available atm, but asap. |
|
Hey, do you have any updates on this? @BorisLeMeec, do you need any help? |
| type CognitoEventUserPoolsCustomEmailSender struct { | ||
| CognitoEventUserPoolsHeader | ||
| Request CognitoEventUserPoolsCustomEmailSenderRequest `json:"request"` | ||
| Response CognitoEventUserPoolsCustomEmailSenderResponse `json:"response"` |
There was a problem hiding this comment.
The docs don't mention a returned response, I think the sender integration isn't quite the same as the Custom Message integration
Email Sender: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-email-sender.html
The custom code of your function must then process and deliver the message.
Compare with Custom Message Trigger: https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-lambda-custom-message.html#cognito-user-pools-lambda-trigger-syntax-custom-message
In the response, specify the custom text to use in messages to your users.
There was a problem hiding this comment.
Probably the response fields should be an empty object:
But the returned response is mentioned here: https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pools-working-with-lambda-triggers.html#working-with-lambda-trigger-sources
|
Is this change still happening? Running into the need for the Email/SMS event models in a project I'm working on |
|
Hey, @BorisLeMeec, @bmoffatt is there an update regarding the support for the custom email sender event? Are there any blockers for merging this? |
|
Bump, any updates on this one? Anyone uses a workaround? |
|
Any updates? |
Issue #, if available:
#370
Description of changes:
added new event struct for support of customEmailSender messages.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.