Skip to content

Fix/daily ci ref input #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharmabikram merged 2 commits into from
Aug 18, 2026
+9 −3
Merged

Fix/daily ci ref input #1697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7001b8
fix(ci): restore Daily CI by passing ref to shared-ci
sharmabikram Aug 18, 2026
60d8139
chore(ci): drop unused workflow_call trigger from ci.yml
sharmabikram Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ permissions:
contents: read
id-token: write

on: [pull_request, workflow_call]
on: [pull_request]

jobs:
shared-ci:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/daily_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ jobs:
strategy:
matrix:
branch: [master, v4.x]
uses: ./.github/workflows/ci.yml
uses: ./.github/workflows/shared-ci.yml
with:
branch: ${{ matrix.branch }}
ref: ${{ matrix.branch }}
notify:
needs:
[
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/shared-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ on:
required: false
type: boolean
default: false
ref:
description: 'Git ref (branch, tag, or SHA) to check out and test. Defaults to the ref that triggered the workflow.'
required: false
type: string
default: ''

env:
NODE_OPTIONS: "--max-old-space-size=4096"
Expand All @@ -34,6 +39,7 @@ jobs:
# Always need repo for test scripts and configuration, even when testing published packages
uses: actions/checkout@v4
with:
ref: ${{ inputs.ref }}
fetch-depth: 0
submodules: true

Expand Down
Loading