feat(plugin): Wire plugin hooks into SDK execution lifecycle#422
Merged
Conversation
ayushiahjolia
force-pushed
the
plugin-wiring
branch
3 times, most recently
from
5cee7e0 to
83e482a
Compare
zhongkechen
reviewed
Jun 2, 2026
ayushiahjolia
force-pushed
the
plugin-wiring
branch
from
83e482a to
0a186ab
Compare
zhongkechen
reviewed
Jun 2, 2026
zhongkechen
reviewed
Jun 2, 2026
zhongkechen
reviewed
Jun 2, 2026
| replayCompletedOperation.set(true); | ||
| } | ||
| // Fire onOperationStart plugin hook (including replay) | ||
| fireOnOperationStart(existing); |
Contributor
There was a problem hiding this comment.
This is different from Python SDK where onOperationStart is called only once for each operation
Contributor
Author
There was a problem hiding this comment.
We will discuss this offline to align on correct behavior
zhongkechen
approved these changes
Jun 2, 2026
Contributor
zhongkechen
left a comment
zhongkechen
left a comment
There was a problem hiding this comment.
Approved with some minor comments which can be addressed later.
ayushiahjolia
force-pushed
the
plugin-wiring
branch
from
0a186ab to
2321aac
Compare
ayushiahjolia
force-pushed
the
plugin-wiring
branch
from
2321aac to
9d08c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
#364
Description
Wire the DurableExecutionPlugin hooks into the SDK so registered plugins receive lifecycle events during execution
Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes? Yes
Integration Tests
Have integration tests been written for these changes? Yes
Examples
Has a new example been added for the change? (if applicable) Yes