Recover circle curves via exact radii-equality check (issue #251)#261
Merged
Conversation
Closed
Circles participate in curve recovery as an exact four-arc representation, keyed on the new iscircle predicate (exact radii equality — guaranteed by the Circle constructor and preserved under angle-preserving transformations) instead of a new Circle type. Also gives circles constant-curvature discretization via circular_arc and a fast bounding-box path. Unequal-radii ellipses keep the discretize-and-warn behavior. Non-breaking: Circle(...) still constructs an equal-radii Ellipse.
gpeairs
force-pushed
the
gp/issue-251-valuecheck
branch
from
July 17, 2026 14:03
50886e6 to
3f9b1e0
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circles participate in curve recovery as an exact four-arc representation, keyed on the new
iscirclepredicate (exact radii equality — guaranteed by the Circle constructor and preserved under angle-preserving transformations) instead of a new Circle type. Also gives circles constant-curvature discretization viacircular_arcand a fast bounding-box path. Unequal-radii ellipses keep the discretize-and-warn behavior. Non-breaking: Circle(...) still constructs an equal-radii Ellipse.