Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31702,16 +31702,26 @@ function _generateTmpName(opts) {
}

/**
* Check the prefix and postfix options
* Check the prefix, postfix, and template options.
*
* Rejects non-string inputs so that a non-string `.includes('..')` cannot evade
* the substring check (e.g. an Array whose `.includes('..')` is element-wise,
* or a duck-typed object with a custom `.includes`), and so that the value is
* not later coerced to a string with traversal sequences via `Array.prototype.join`
* or `path.join`.
*
* @private
*/
function _assertPath(path) {
if (path.includes("..")) {
function _assertPath(option, value) {
if (typeof value !== 'string') {
throw new Error(`${option} option must be a string, got "${typeof value}".`);
}

if (value.includes("..")) {
throw new Error("Relative value not allowed");
}

return path;
return value;
}

/**
Expand All @@ -31734,8 +31744,13 @@ function _assertOptionsBase(options) {
}

/* istanbul ignore else */
if (!_isUndefined(options.template) && !options.template.match(TEMPLATE_PATTERN)) {
throw new Error(`Invalid template, found "${options.template}".`);
if (!_isUndefined(options.template)) {
if (typeof options.template !== 'string') {
throw new Error(`template option must be a string, got "${typeof options.template}".`);
}
if (!options.template.match(TEMPLATE_PATTERN)) {
throw new Error(`Invalid template, found "${options.template}".`);
}
}

/* istanbul ignore else */
Expand All @@ -31751,9 +31766,9 @@ function _assertOptionsBase(options) {
options.unsafeCleanup = !!options.unsafeCleanup;

// for completeness' sake only, also keep (multiple) blanks if the user, purportedly sane, requests us to
options.prefix = _isUndefined(options.prefix) ? '' : _assertPath(options.prefix);
options.postfix = _isUndefined(options.postfix) ? '' : _assertPath(options.postfix);
options.template = _isUndefined(options.template) ? undefined : _assertPath(options.template);
options.prefix = _isUndefined(options.prefix) ? '' : _assertPath('prefix', options.prefix);
options.postfix = _isUndefined(options.postfix) ? '' : _assertPath('postfix', options.postfix);
options.template = _isUndefined(options.template) ? undefined : _assertPath('template', options.template);
}

/**
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"dependencies": {
"@actions/core": "^2.0.2",
"@aws-sdk/client-ecs": "^3.1076.0",
"tmp": "^0.2.6"
"tmp": "^0.2.7"
},
"devDependencies": {
"@vercel/ncc": "^0.38.4",
Expand Down