Repository navigation
Conversation
hholoubk
reviewed
Nov 13, 2026
hholoubk
reviewed
Nov 13, 2026
crobinso
force-pushed
the
v2v-windows-firstboot-prep
branch
from
November 13, 2026 18:23
0dd9344 to
eddc9e8
Compare
We log it line by line right after this
VMChecker should reliably tell us when the VM has fully completed firstboot. Move all console checks to after VMChecker, and drop the remaining inline attempts at reboot detection
+ rename it to v2v_firstboot_timeout + have different timeout values for linux vs windows. windows has more reboots and takes longer + add some infra so that we tick down the timeout change across every login attempt, since for windows there can be many
In practice it does not seem like we can rely on this. Instead just keep trying to reconnect until v2v_firstboot_timeout expires
This let's us leverage libvirt+qemu to tell use when the guest agent is configured and available. When virt-v2v is new enough, this saves us from dropping into the network console until we know the firstboot process is complete, by presence of the sentinel file in the VM which we extract with qemu-guest-agent commands. It also improves real world test coverage, since we are confirming the guest agent is actually working. Used only for windows guests for now but this is valid for linux too, but that will need more testing.
The guest agent liveness check is a more useful check for this
crobinso
force-pushed
the
v2v-windows-firstboot-prep
branch
from
November 14, 2026 20:28
eddc9e8 to
d3a3024
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous round of windows firstboot flakyness fixing did not work. So here's another attempt.
Reworks how we handle firstboot timeout and basically just keeps spam re-attempts until the timeout expires, but with some simplifications and improvements along the way.
I'll throw this at our internal CI and see what happens