Repository navigation
v2v: series of misc cleanups - #6964
Merged
Merged
Conversation
This is not anything to do with virt-v2v. If there's an issue here it's either qemu/kvm/libvirt CPU model bits or an OS bug. If that happens it's good to know but the one case we know this fails we are ignoring it anyways. So just drop the check Signed-off-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
Used in a couple places as max timeout we expect a single windows boot+configure cycle to take. Possibly this could be wrong if qemu-ga install fails and needs to retry. Signed-off-by: Cole Robinson <crobinso@redhat.com>
This is an issue in production, not sure about CI though. This makes it stick out a bit more in logs. Signed-off-by: Cole Robinson <crobinso@redhat.com>
+ log at info level + track how long the VM was up Signed-off-by: Cole Robinson <crobinso@redhat.com>
It's the only output variant nowadays
The multi command works fine for the one case we are annotating with `sles`
Nothing is checking for windows os_version anymore
The only case this is being used is for os_version = 'rhel7', so hardcode that. Going forward, if we need os_version, we should be getting it from vmchecker, which attempts to autodetect it from filled in XML value
Not via passed in argument, which makes it hard to follow where it is coming from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some random v2v/ cleanups and improvements I've accumulated. See individual commits for details