Skip to content

Fix abort save cleanup after setup failures #6959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crobinso merged 1 commit into from
Nov 9, 2026
Merged

Fix abort save cleanup after setup failures #6959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libvirt/tests/src/save_and_restore/abort_save.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ def run(test, params, env):

vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name)
bkxml = vmxml.copy()
save_path = None
virsh_session = None

try:
vm.start()
Expand Down Expand Up @@ -60,7 +62,8 @@ def run(test, params, env):
test.fail("There is no 'save canceled' words in the domstate outputs!")
virsh.shutdown(vm_name, debug=True, ignore_status=False)
finally:
virsh_session.close()
if virsh_session:
virsh_session.close()
bkxml.sync()
if os.path.exists(save_path):
if save_path and os.path.exists(save_path):
os.remove(save_path)