Skip to content

Fix expected err_msg for virtio iommu additional attributes - #6876

Open
hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:fix/virtio-iommu-additional-attributes-err-msg
Open

hholoubk wants to merge 1 commit into
autotest:masterfrom
hholoubk:fix/virtio-iommu-additional-attributes-err-msg

Conversation

@hholoubk

@hholoubk hholoubk commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Libvirt now reports "doesn't support some additional attributes" instead of "doesn't support additional attributes". Update the expected error string so caching_mode, eim, and iotlb variants pass on RHEL 10.3.

Assisted-by: Claude AI (cursor) ~80%

@coderabbitai

coderabbitai Bot commented Jun 1, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1db01b01-1b19-4d0a-95e5-7f0d8c31afb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@crobinso crobinso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine with the comment tweaks. PR is in draft. do you still need it?

@hholoubk
hholoubk force-pushed the fix/virtio-iommu-additional-attributes-err-msg branch from f0a6b97 to a0825da Compare November 13, 2026 11:35
Use a regular expression so the negative test accepts libvirt errors
with or without the word "some". Document aw_bits support on newer
libvirt versions.

Assisted-by: Codex (~15% contribution)
Signed-off-by: hholoubk <hholoubk@redhat.com>
@hholoubk
hholoubk force-pushed the fix/virtio-iommu-additional-attributes-err-msg branch from a0825da to 9056ade Compare November 13, 2026 11:44
@hholoubk
hholoubk marked this pull request as ready for review November 13, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants