This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Open
Conversation
added 2 commits
January 11, 2019 20:52
Also make them pass on my laptop.
Contributor
Author
|
Ah yes, good old "it works on my laptop now but not on CI". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
It really wasn't clear what these tests were doing before, which was partly because the width of each tab was not explicitly defined. The tests themselves were also wrong -
scrollIntoViewdoesn't do anything if the item is at least partially visible. I've updated these tests to properly test that scrolling works as expected, and also updatedscrollIntoViewto use the new options listed at https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView.Alternate Designs
None.
Benefits
The purpose of these tests should be more clear and the intended behavior more easy to follow.
Possible Drawbacks
None.
Applicable Issues
None.