Skip to content

Fix route schema decoding and serialization - #75

Open
dajiaohuang wants to merge 1 commit into
assetnote:mainfrom
dajiaohuang:fix/parse-and-route-serialization
Open

dajiaohuang wants to merge 1 commit into
assetnote:mainfrom
dajiaohuang:fix/parse-and-route-serialization

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

  • Use the Swagger field names parameters, consumes, and produces so JSON decoding retains operation parameters and content types.
  • Serialize schema properties in stable key order when creating route crumbs.
  • Write each target header once in Target.Write, with a regression test for emitted bytes and count.

Validation

  • go test -count=5 ./pkg/http ./internal/scan ./pkg/kitebuilder ./pkg/proute
  • go build ./...
  • go run ./cmd/kiterunner --help
  • git diff --check

The full go test ./... suite was not run: pkg/kiterunner tests target pre-existing localhost:14000+ services rather than task-owned fixtures. No external hosts or target scans were used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant