fix: skip __pycache__ dirs when merging namespace packages#1101
Draft
xangcastle wants to merge 1 commit into
Draft
fix: skip __pycache__ dirs when merging namespace packages#1101xangcastle wants to merge 1 commit into
xangcastle wants to merge 1 commit into
Conversation
✨ Aspect Workflows Tasks📅 Thu Jun 11 04:04:47 UTC 2026 ❌ 3 failed tasks
✅ 4 successful tasks
🛠️ Fix❌ buildifier (buildifier)Install 🔁 Reproduce❌ buildifier (buildifier)❌ test (test-e2e-bazel-8 · test-e2e-bazel-9)Install ⏱ Last updated Thu Jun 11 04:42:03 UTC 2026 · 📊 GitHub API quota 175/15,000 (1% used, resets in 15m, throttle 3×) |
4b8e234 to
d487f0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uv or the host Python compiles a shared namespace init.py to bytecode, the resulting .pyc files embed the absolute source path in their headers. Two packages sharing the same namespace therefore produce non-identical .pyc files, which triggered CollisionResolutionStrategy::Error in create_symlinks.
Python regenerates .pyc files on demand, so pycache directories can safely be omitted from the symlink forest. The fix skips any directory named pycache in create_symlinks.
Changes are visible to end-users: no
Test plan