perf: migrate bash launcher to hermetic-build#1045
Conversation
|
491171d to
dbccde5
Compare
| # Make wheel-declared console scripts reachable via `subprocess.run("name", ...)`. | ||
| _venv_bin = os.path.join(sys.prefix, "bin") | ||
| if _venv_bin not in os.environ.get("PATH", "").split(os.pathsep): | ||
| os.environ["PATH"] = _venv_bin + os.pathsep + os.environ.get("PATH", "") |
There was a problem hiding this comment.
Does anyone know of a better way of doing this? Should it be opt-in?
There was a problem hiding this comment.
I've found no better way of doing this. Alternatives would be:
- wrapper script, exactly what this PR is dropping
hermetic_launchersupporting env vars (or appending to them specifically) which seems like a bad idea
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbccde5e29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b5ecd19 to
fe6c33c
Compare
✨ Aspect Workflows Tasks📅 Fri Jun 5 20:57:36 UTC 2026 ✅ 6 successful tasks
⏱ Last updated Fri Jun 5 21:00:40 UTC 2026 · 📊 GitHub API quota 317/15,000 (2% used, resets in 37m) |
py_binary startup benchmark
sys.path quality
|
e7aa847 to
f439e95
Compare
36b72f8 to
1ae45b0
Compare


Changes are visible to end-users: yes
Use https://github.com/hermeticbuild/hermetic-launcher to launch the python toolchain instead of depending on a shell wrapper.
Test plan