Skip to content

Various additions/fixes#155

Open
CrashTestJava wants to merge 8 commits into
aseprite:mainfrom
CrashTestJava:various-additions/fixes
Open

Various additions/fixes#155
CrashTestJava wants to merge 8 commits into
aseprite:mainfrom
CrashTestJava:various-additions/fixes

Conversation

@CrashTestJava
Copy link
Copy Markdown
Member

@CrashTestJava CrashTestJava commented Apr 1, 2026

@CrashTestJava CrashTestJava marked this pull request as ready for review April 9, 2026 02:15
@CrashTestJava CrashTestJava requested a review from dacap April 9, 2026 02:15
@Gasparoken Gasparoken self-assigned this May 27, 2026
@Gasparoken
Copy link
Copy Markdown
Member

Gasparoken commented May 27, 2026

LGTM👌🏼!
Remove it unless you're still working on it:

@Gasparoken Gasparoken self-requested a review May 27, 2026 18:01
@CrashTestJava
Copy link
Copy Markdown
Member Author

CrashTestJava commented May 27, 2026

I initially (after I had looked into the PR a little more) didn't think it was necessary to document the UI issue as the annotations ckaiser added to the command page mention the ui parameter already, and it wouldn't really matter for the commands that don't have UI; that's why I didn't delete/check it off of the checklist. In hindsight though it's probably a good idea for me to look through the commands and add the ui parameter/annotation to any command with UI that doesn't have it already. I'll add that to the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants