libbpf: fix const correctness in resolve_full_path for gcc15#474
Merged
amazingfate merged 1 commit intoarmbian:rk-6.1-rkr5.1from Apr 25, 2026
Merged
libbpf: fix const correctness in resolve_full_path for gcc15#474amazingfate merged 1 commit intoarmbian:rk-6.1-rkr5.1from
amazingfate merged 1 commit intoarmbian:rk-6.1-rkr5.1from
Conversation
gcc 15's C library headers use _Generic to return const char * from strchr() when passed a const char * input. With -Werror=discarded- qualifiers, assigning this to a char * fails. next_path only uses the pointer for arithmetic to calculate segment length, never modifies the string. const char * is the correct type. Signed-off-by: EvilOlaf <evilolaf@users.noreply.github.com>
Collaborator
|
we may rebase to newer rk sdk release, using upstream fix would make developers treat this patch more clearly when bump ing kernel(drop or keep this patch). |
Member
Author
|
I'd leave this at your discretion. Your insights are most likely deeper than mine. |
Member
|
This is probably still good to merge? As I don't expect this rebase to happen soon-ish? |
Collaborator
|
I just checked there is no related fix in 6.1 lts, and the one for 6.18 in upstream has patched some code not in 6.1 source tree. This PR is fine. |
amazingfate
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendorheader compilation fails when building withresoluteas target. This is likely due to gcc15 being default in Resolute. I threw this at llm and this seem to fix the compilation.This was originally discovered because aic8800 compilation failed due to failing headers.
This also looks quite similar to the mainline upstream fix: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.18.24&id=ab21cf885fb2af179c44d8beeabd716133b9385d