Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17004.
reset(false)reassigned every other setting in the!_keepSettingsblock but skippedm_experimentalandm_debugInfoSelection, so a stack reused aftersetExperimental(true)orselectDebugInfo(DebugInfoSelection::None())kept those into the next compilation. Both now go back to the header defaults,falseandDebugInfoSelection::Default(). I went through the remaining public setters and did not find another member the block misses.There is no getter for either, so the two new tests in
SolidityCompiler.cppobserve them the way a caller would: thesettings.experimentalkey in the metadata, and the source location comments inassemblyString. Each checksreset(true)keeps the value andreset(false)drops it, and each fails ondevelopwithout the change.Checklist
AI Disclosure
Claude Code was used to draft the fix, the two unit tests and the Changelog line. I reviewed the diff, built
soltestlocally and ran theSolidityCompilersuite against it.