Conversation
The tag ID was masked to 64 bits and then stored in a size_t, which is only 32 bits wide on platforms such as the WebAssembly build. IDs that do not fit in 32 bits were silently cut down to their lower 32 bits, turning the result into a reference to an unrelated tag. Keep the ID in a uint64_t and reject values that do not fit in a size_t instead.
riba2534
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16947.
toSubAssemblyTagmasked the tag ID to 64 bits and then stored it in asize_t. On 32-bitsize_t(e.g. the WASM build) large IDs were truncated to the lower 32 bits and pointed at unrelated tags.Keep the ID in a
uint64_tand reject values that do not fit insize_t. Coverage for an ID above 2^32 is intest/libevmasm/Assembler.cpp.