Conversation
|
There was an error when running Please check that your changes are working as intended. |
msooseth
marked this pull request as ready for review
September 8, 2026 16:23
msooseth
force-pushed
the
mate-ssa-invariants-only
branch
from
September 16, 2026 14:24
2dfd7ed to
1a5b95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds invariant checks to SSA-CFG. Currently, the SSA-CFG fails the
phis at the beginning, sol it's disabled. MainExit count is also often 0, even though I think it should be 1? Also disabled. Both are disabled with#if 0so it's ugly as hell and should be quite visible. All is gated with SLOW_DEBUG, but this is ugly and will need to go. Look past it please.Checks added are listed below.
InstructionStore:
SSACFG:
Things I need help with
SLOW_DEBUG. Some of these should run always, and some only in a debug build. We should decide which ones._ctx? It's built, always, but only used when emitting an error, which could be expensive. Perhaps only pass non-empty_ctxin debug build only?#if 0-s in SSACFG.cpp are things we want, but are not currently true. Should they stay?SSACFG.hhas a public&private block inSLOW_DEBUG, which makes it a bit messy. But also not sure how to structure it otherwise. Maybe a friend class? Perhaps would make more sense?Checklist
AI Disclosure