devel: import bumpbuddy out of date information #598
+132
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
force-pushed
the
bump-buddy-integration
branch
from
cd4f5e3 to
10577b6
Compare
jelly
force-pushed
the
bump-buddy-integration
branch
from
10577b6 to
d060bd0
Compare
anthraxx
requested changes
Jan 8, 2026
Member
anthraxx
left a comment
anthraxx
left a comment
There was a problem hiding this comment.
Overall awesome change, I haven't yet tested it locally, but except the small proposed changes this looks like it should work <3
Comment on lines
+117
to
+118
| if not pkgdata['out_of_date']: | ||
| continue |
Member
There was a problem hiding this comment.
Suggested change
| if not pkgdata['out_of_date']: | |
| continue |
We shouldn't only process entries marked as out_of_date by bumpbuddy if we want to make sure we are not prone to timing issues. This boolean field is only representing out of date between the main Git branch and the upstream version, Archweb needs to calculate it's own out-of-date state and subsequently must not skip entries marked up-to-date.
| current_time = now() | ||
| # Compatibility for old json output without issue | ||
| if 'issue' in pkgdata: | ||
| issue_url = f"{settings.GITLAB_PACKAGES_REPO}/{pkgbase}/-/issues/{pkgdata['issue']}" |
Member
There was a problem hiding this comment.
For the corrent pkgbase in gitlab url's we need to
scm_pkgbase = urlquote(gitlab_project_name_to_path(pkgbase))
Member
|
Thanks for putting the work into this 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.