Fix for spreadsheet scroll jump on inline row edit #2738

Ramudur19 · 2025-12-25T20:02:56Z

Avoid invalidating the full rows query on inline edits and updated the row locally to preserve pagination and scroll position.

What does this PR do?

This PR fixes an issue where editing a cell in the spreadsheet caused the view to scroll back to the top.

The root cause was that inline row edits were invalidating the entire rows query, which triggered a re-fetch starting from offset 0. This reset pagination state and caused the spreadsheet to lose its scroll position.

For inline edits, a full data reload isn’t necessary because the row is already updated locally and persisted to the backend. This change avoids invalidating the full rows query for inline edits and instead updates the edited row in the local store.

As a result, pagination and scroll position remain stable after editing a row.

Test Plan

Open a database table with a large number of rows.
Scroll down to any position in the table.
Edit a cell inline and save the change.
Verify that:
The edited value updates correctly.
The scroll position does not reset.
Pagination state remains unchanged.
Refresh the page and confirm the updated value persists.

scroll.jump.mp4

Related PRs and Issues

Closes #2689

Have you read the Contributing Guidelines on issues?

Yes, I have read and followed the contributing guidelines.

Summary by CodeRabbit

Refactor
- Improved row update handling in database table spreadsheet views for more efficient data management.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Avoid invalidating the full rows query on inline edits and updated the row locally to preserve pagination and scroll position.

appwrite · 2025-12-25T20:03:00Z

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Failed	Authorize	Preview URL

Tip

Roll back Sites deployments instantly by switching between versions

coderabbitai · 2025-12-25T20:03:09Z

Walkthrough

The change modifies row update handling in a spreadsheet component by replacing a full invalidation call with selective in-place updating. After a row is updated, the code now uses a Map-based index lookup to locate the row in the paginatedRows array. If found, it updates that specific row directly; if not found, no in-memory update occurs. Event tracking and notification logic remain unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: preventing scroll jump when editing cells inline in the spreadsheet, which matches the changeset's purpose.
Linked Issues check	✅ Passed	The PR directly addresses issue #2689 by replacing full query invalidation with selective in-place updates, preventing the scroll jump that occurred during inline row edits.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to fixing the scroll jump issue via selective row updates; no unrelated modifications to event tracking, notifications, or public APIs are introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)
633-639: Consider adding debug logging for skipped updates.

When a row is edited but not present in the current paginated view (rowIndex === undefined), the local update is silently skipped. While this appears intentional and aligns with the PR's goal, adding optional debug logging could aid troubleshooting.
🔎 Proposed enhancement with debug logging
 const rowIndex = rowIndexMap.get(row.$id);
 if (rowIndex !== undefined) {
     paginatedRows.update(
         rowIndex,
         row as Models.DefaultRow
     );
+} else {
+    // Row not in current page view; backend updated but skipping local UI sync
+    console.debug(`Row ${row.$id} updated in backend but not in current paginated view`);
 }

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e446f7f and 8edc7cc.

📒 Files selected for processing (1)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

🧰 Additional context used

📓 Path-based instructions (5)

**/*.{ts,tsx,js,jsx,svelte}